From: Philip Chimento Date: Mon, 1 Jan 2024 00:08:20 +0000 (-0500) Subject: scripting: Use logError to format error stack X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~281^2~2^2~183 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e3ea12b8d57783a566330651383a15ecab4e6565;p=gnome-shell.git scripting: Use logError to format error stack Instead of manually formatting the error stack, use logError() to display the error. logError() displays the stack already. Part-of: --- diff --git a/js/ui/scripting.js b/js/ui/scripting.js index db245c0f4..c38f07d17 100644 --- a/js/ui/scripting.js +++ b/js/ui/scripting.js @@ -295,14 +295,14 @@ async function _runPerfScript(scriptModule, outputFile) { try { await scriptModule.run(); } catch (err) { - log(`Script failed: ${err}\n${err.stack}`); + logError(err, 'Script failed'); Meta.exit(Meta.ExitCode.ERROR); } try { _collect(scriptModule, outputFile); } catch (err) { - log(`Script failed: ${err}\n${err.stack}`); + logError(err, 'Script failed'); Meta.exit(Meta.ExitCode.ERROR); } @@ -311,7 +311,7 @@ async function _runPerfScript(scriptModule, outputFile) { if (perfHelper._autoExit) perfHelper.ExitSync(); } catch (err) { - log(`Failed to exit helper: ${err}\n${err.stack}`); + logError(err, 'Failed to exit helper'); Meta.exit(Meta.ExitCode.ERROR); }